fixup for #7454 - always run asm tests with PIC#7716
Conversation
MartinNowak
commented
Jan 15, 2018
- as the purpose is really not testing call and symobl ABIs
- always use -fPIC so we're compatible with PIE-by-default platforms
- as the purpose is really not testing calling and symobl ABIs - always use -fPIC so we're compatible with PIE platforms
|
Thanks for your pull request, @MartinNowak! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
This appears to be trying to solve a non-existent problem. The test works for both PIC and non-PIC builds. If we pull this we lose the test on non-PIC builds and all the work and knowledge that went into creating it. I don't see that there's anything to "fix". Furthermore, @MartinNowak, where were you a month ago when we were working on this and pinging you about it? |
|
How about we making the testsuite runnable on a |
It's a redundant test that checks the same thing, b/c vector filling doesn't depend on PIC.
Check again, I've stripped PIC from the newly added test_cdstrpar because I couldn't see any sense in it. It is likely suffering from the same problem you were solving for test_cdvecfill. |
Exactly! I'll revisit this PR when we have the test suite running on PIE hardened systems and added to the CIs. |
JinShil
left a comment
There was a problem hiding this comment.
Ok, It finally dawned on me what @MartinNowak is saying with regard to the redundancy of the existing implementation. Therefore approving.
|
Auto-merge toggled off. Waiting for feedback from others on #7427 (comment) |
Dismissing review for now. Waiting for feedback on comments in #7427.